Vladsz83 commented on code in PR #11539:
URL: https://github.com/apache/ignite/pull/11539#discussion_r1773833870
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/service/IgniteServiceProcessor.java:
##########
@@ -1764,11 +1781,21 @@ else if (req instanceof ServiceUndeploymentRequest)
"exists : [" + "srvcId" + reqSrvcId + ", srvcTop=" +
oldDesc.topologySnapshot() + ']');
}
else {
- ServiceConfiguration cfg =
((ServiceDeploymentRequest)req).configuration();
+ LazyServiceConfiguration cfg =
((ServiceDeploymentRequest)req).configuration();
if (ctx.security().enabled())
err =
checkPermissions(((ServiceDeploymentRequest)req).configuration().getName(),
SERVICE_DEPLOY);
+ if (err == null) {
+ try {
+ unmarshalNodeFilterIfNeeded(cfg);
+ }
+ catch (IgniteCheckedException e) {
+ err = new IgniteCheckedException("Failed to deploy
service, " +
+ "unable to unmarshal node filter, cfg=" + cfg,
e);
+ }
Review Comment:
Suggestion: "node filter" -> "service node filter". A bit better. We have
cache node filter in Ignite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
