tkalkirill commented on code in PR #4437:
URL: https://github.com/apache/ignite-3/pull/4437#discussion_r1774678111
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpointer.java:
##########
@@ -484,8 +484,21 @@ boolean writePages(
// Wait and check for errors.
CompletableFuture.allOf(futures).join();
- // Must re-check shutdown flag here because threads may have skipped
some pages.
- // If so, we should not put finish checkpoint mark.
+ // Must re-check shutdown flag here because threads may have skipped
some pages because of it.
+ // If so, we should not finish checkpoint.
+ if (shutdownNow.getAsBoolean()) {
+ currentCheckpointProgress.fail(new NodeStoppingException("Node is
stopping."));
+
+ return false;
+ }
+
+ // Stops new blockings on page replacement and wait for all those
started up to this point.
+ // Will complete normally or with the first error on one of the page
replacements.
+ // join() is used intentionally as above.
+ currentCheckpointProgress.stopBlockingFsyncOnPageReplacement().join();
Review Comment:
Create https://issues.apache.org/jira/browse/IGNITE-23266 for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
