skorotkov commented on code in PR #11554:
URL: https://github.com/apache/ignite/pull/11554#discussion_r1774763390
##########
modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py:
##########
@@ -245,12 +245,16 @@ def envs(self):
"""
:return: environment set.
"""
- return {
+ environment_dict = {
'EXCLUDE_TEST_CLASSES': 'true',
'IGNITE_LOG_DIR': self.service.log_dir,
'USER_LIBS': ":".join(self.libs()),
"MAIN_CLASS": self.service.main_java_class
}
+ if "direct-io" not in self.modules():
Review Comment:
Please follow here the "Semantic Units" rule from the coding guidelines:
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-SemanticUnits
It's for java but general requirements are also need to be followed in
python code as well.
So, add empty line before this line.
##########
modules/ducktests/tests/ignitetest/tests/thin_client_query_test.py:
##########
@@ -89,7 +89,9 @@ def envs(self):
Skip the module target directory while building classpath.
"""
envs = super().envs()
-
- envs["EXCLUDE_MODULES"] = "ducktests"
+ if envs.get("EXCLUDE_MODULES") is not None:
Review Comment:
Add empty line before this one.
##########
modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py:
##########
@@ -245,12 +245,16 @@ def envs(self):
"""
:return: environment set.
"""
- return {
+ environment_dict = {
'EXCLUDE_TEST_CLASSES': 'true',
'IGNITE_LOG_DIR': self.service.log_dir,
'USER_LIBS': ":".join(self.libs()),
"MAIN_CLASS": self.service.main_java_class
}
+ if "direct-io" not in self.modules():
+ # IGNITE-23016, excluded to avoid implicit usage
+ environment_dict['EXCLUDE_MODULES'] = "direct-io"
+ return environment_dict
Review Comment:
Add empty line before this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
