rpuch commented on code in PR #4433:
URL: https://github.com/apache/ignite-3/pull/4433#discussion_r1774937130
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageLearnerManager.java:
##########
@@ -62,6 +64,10 @@ CompletableFuture<Void> updateLearners(long term) {
}
CompletableFuture<Void> addLearner(RaftGroupService raftService,
ClusterNode learner) {
+ if (!learnersAdditionEnabled) {
Review Comment:
Existing naming seems to match the actual events and methods
(`addLearner()`) better, I'm not sure it should be changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
