tkalkirill commented on code in PR #4465:
URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778478258
##########
modules/metastorage/src/testFixtures/java/org/apache/ignite/internal/metastorage/server/SimpleInMemoryKeyValueStorage.java:
##########
@@ -547,78 +557,42 @@ private boolean doRemove(byte[] key, long curRev) {
}
/**
- * Compacts all entries by the given key, removing revision that are no
longer needed.
- * Last entry with a revision lesser or equal to the {@code
minRevisionToKeep} and all consecutive entries will be preserved.
- * If the first entry to keep is a tombstone, it will be removed.
+ * Compacts the key, see the documentation of {@link
KeyValueStorage#compact} for examples.
*
- * @param key A key.
- * @param revs All revisions of a key.
- * @param compactedKeysIdx Out parameter, revisions that need to be kept
must be put here.
- * @param compactedRevsIdx Out parameter, values that need to be kept must
be put here.
- * @param minRevisionToKeep Minimum revision that should be kept.
+ * @param key Target key.
+ * @param revs Key revisions.
+ * @param compactionRevision Revision up to which the key will be
compacted.
Review Comment:
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
