tkalkirill commented on code in PR #4529:
URL: https://github.com/apache/ignite-3/pull/4529#discussion_r1793381465
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorage.java:
##########
@@ -132,21 +131,23 @@ public interface KeyValueStorage extends
ManuallyCloseable {
List<Entry> get(byte[] key, long revLowerBound, long revUpperBound);
/**
- * Returns all entries corresponding to given keys.
+ * Returns the latest version of an entries by keys.
+ *
+ * <p>Never throws {@link CompactedException}.</p>
*
- * @param keys Keys collection.
- * @return Entries corresponding to given keys.
+ * @param keys Not empty keys.
*/
- Collection<Entry> getAll(List<byte[]> keys);
+ List<Entry> getAll(List<byte[]> keys);
/**
- * Returns all entries corresponding to given keys and bounded by the
given revision.
+ * Returns an entries by the given keys and bounded by the given revision.
*
- * @param keys Keys collection.
+ * @param keys Not empty keys.
* @param revUpperBound Upper bound of revision.
- * @return Entries corresponding to given keys.
+ * @throws CompactedException If getting one of an entries will throw this
exception as if using {@link #get(byte[], long)}.
Review Comment:
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
