JAkutenshi commented on code in PR #4477:
URL: https://github.com/apache/ignite-3/pull/4477#discussion_r1796727703
##########
modules/replicator/src/testFixtures/java/org/apache/ignite/internal/raft/client/AbstractTopologyAwareGroupServiceTest.java:
##########
@@ -215,7 +215,7 @@ private IgniteBiTuple<TopologyAwareRaftGroupService,
TopologyAwareRaftGroupServi
assertNotNull(raftClient);
- raftClient.refreshLeader().get();
+ raftClient.refreshLeader().get(WAIT_TIMEOUT_MILLIS,
TimeUnit.MILLISECONDS);
Review Comment:
Didn't noticed internal limitation, just was triggered with `get()` without
a timeout. Removed.
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/RocksDbSharedLogStorage.java:
##########
@@ -380,6 +380,8 @@ public LogEntry getEntry(long index) {
}
protected byte[] getValueFromRocksDb(byte[] keyBytes) throws
RocksDBException {
+ assert !db.isClosed();
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]