alievmirza commented on code in PR #4552:
URL: https://github.com/apache/ignite-3/pull/4552#discussion_r1801088939
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -604,6 +604,12 @@ public boolean onBeforeApply(Command command) {
return false;
}
+ @Override
+ public void onLeaderStop() {
+ maxObservableSafeTime = -1;
Review Comment:
I was thinking about the scenario when we've started to handle
onBeforeApply,
and in the place where we write `maxObservableSafeTime = proposedSafeTime`
```
if (proposedSafeTime >= maxObservableSafeTime) {
maxObservableSafeTime = proposedSafeTime;
}
```
right before that `onLeaderStop` logic is performed, so we will have
```
maxObservableSafeTime == some value > 0
maxObservableSafeTime == -1
maxObservableSafeTime == proposedSafeTime
```
and finished `onLeaderStop` logic, so `maxObservableSafeTime` won't be -1
as we were expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
