tkalkirill commented on code in PR #4576:
URL: https://github.com/apache/ignite-3/pull/4576#discussion_r1803463037
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/LocalStateStorageTest.java:
##########
@@ -55,7 +55,7 @@ void setUp() {
void serializationAndDeserialization() {
LocalState originalState = new LocalState(
Set.of("a", "b"),
- ClusterTag.clusterTag(CMG_MESSAGES_FACTORY, "cluster", new
UUID(0x12345678L, 0x87654321L))
+ ClusterTag.clusterTag(CMG_MESSAGES_FACTORY, "cluster", new
UUID(0x1234567890ABCDEFL, 0xFEDCBA0987654321L))
Review Comment:
Why change it?
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/ClusterStatePersistentSerializerTest.java:
##########
@@ -43,9 +42,12 @@ void serializationAndDeserializationWithoutNulls() {
.cmgNodes(Set.of("a", "b"))
.metaStorageNodes(Set.of("c", "d"))
.version("3.0.0")
- .clusterTag(ClusterTag.randomClusterTag(CMG_MESSAGES_FACTORY,
"cluster"))
+ .clusterTag(ClusterTag.clusterTag(CMG_MESSAGES_FACTORY,
"cluster", new UUID(0x1234567890ABCDEFL, 0xFEDCBA0987654321L)))
Review Comment:
Why change it?
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/topology/api/LogicalTopologySnapshotSerializerTest.java:
##########
@@ -62,9 +62,9 @@ private static LogicalNode node(int index) {
@Test
void v1CanBeDeserialized() {
- byte[] bytes =
Base64.getDecoder().decode("Ae++Q3wDAe++QwHvvkO+uv7K776t3gAAAAAAAAAABW5vZGUwBWhvc3QwuRcBCnJlc3QtaG9zdDBRvAMCBHVrZ"
- +
"XkFdXZhbDACBHNrZXkFc3ZhbDADBXByb2YxBXByb2YyAe++QwHvvkO+uv7K776t3gEAAAAAAAAABW5vZGUxBWhvc3QxuhcBCnJlc3QtaG9zdDFSvQMCBH"
- +
"VrZXkFdXZhbDECBHNrZXkFc3ZhbDEDBXByb2YxBXByb2YyAQAAAAAAAAACAAAAAAAAAA==");
+ byte[] bytes =
Base64.getDecoder().decode("Ae++Q3wDAe++QwHvvkO+uv7K776t3gAAAAAAAAAABm5vZGUwBmhvc3QwuRcBC3Jlc3QtaG9zdDBRvAMCBXV"
+ +
"rZXkGdXZhbDACBXNrZXkGc3ZhbDADBnByb2YxBnByb2YyAe++QwHvvkO+uv7K776t3gEAAAAAAAAABm5vZGUxBmhvc3QxuhcBC3Jlc3QtaG9zdDFSvQ"
+ +
"MCBXVrZXkGdXZhbDECBXNrZXkGc3ZhbDEDBnByb2YxBnByb2YyAQAAAAAAAAACAAAAAAAAAA==");
Review Comment:
Why change it?
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/topology/api/LogicalTopologySnapshotSerializerTest.java:
##########
@@ -62,9 +62,9 @@ private static LogicalNode node(int index) {
@Test
void v1CanBeDeserialized() {
- byte[] bytes =
Base64.getDecoder().decode("Ae++Q3wDAe++QwHvvkO+uv7K776t3gAAAAAAAAAABW5vZGUwBWhvc3QwuRcBCnJlc3QtaG9zdDBRvAMCBHVrZ"
- +
"XkFdXZhbDACBHNrZXkFc3ZhbDADBXByb2YxBXByb2YyAe++QwHvvkO+uv7K776t3gEAAAAAAAAABW5vZGUxBWhvc3QxuhcBCnJlc3QtaG9zdDFSvQMCBH"
- +
"VrZXkFdXZhbDECBHNrZXkFc3ZhbDEDBXByb2YxBXByb2YyAQAAAAAAAAACAAAAAAAAAA==");
+ byte[] bytes =
Base64.getDecoder().decode("Ae++Q3wDAe++QwHvvkO+uv7K776t3gAAAAAAAAAABm5vZGUwBmhvc3QwuRcBC3Jlc3QtaG9zdDBRvAMCBXV"
+ +
"rZXkGdXZhbDACBXNrZXkGc3ZhbDADBnByb2YxBnByb2YyAe++QwHvvkO+uv7K776t3gEAAAAAAAAABm5vZGUxBmhvc3QxuhcBC3Jlc3QtaG9zdDFSvQ"
Review Comment:
Why change it?
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/topology/api/LogicalNodeSerializerTest.java:
##########
@@ -59,8 +59,8 @@ void serializationAndDeserialization() {
@Test
void v1CanBeDeserialized() {
- byte[] bytes =
Base64.getDecoder().decode("Ae++QwHvvkPvzauQeFY0EiFDZYcJutz+BHRlc3QEaG9zdLkXAQhleHQtaG9zdLoXuxcCBHVrZXkEdXZhbAI"
- + "Ec2tleQRzdmFsAgdwcm9maWxl");
+ byte[] bytes =
Base64.getDecoder().decode("Ae++QwHvvkPvzauQeFY0EiFDZYcJutz+BXRlc3QFaG9zdLkXAQlleHQtaG9zdLoXuxcCBXVrZXkFdXZhbAI"
Review Comment:
Why change it?
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/topology/api/LogicalTopologySnapshotSerializerTest.java:
##########
@@ -62,9 +62,9 @@ private static LogicalNode node(int index) {
@Test
void v1CanBeDeserialized() {
- byte[] bytes =
Base64.getDecoder().decode("Ae++Q3wDAe++QwHvvkO+uv7K776t3gAAAAAAAAAABW5vZGUwBWhvc3QwuRcBCnJlc3QtaG9zdDBRvAMCBHVrZ"
- +
"XkFdXZhbDACBHNrZXkFc3ZhbDADBXByb2YxBXByb2YyAe++QwHvvkO+uv7K776t3gEAAAAAAAAABW5vZGUxBWhvc3QxuhcBCnJlc3QtaG9zdDFSvQMCBH"
- +
"VrZXkFdXZhbDECBHNrZXkFc3ZhbDEDBXByb2YxBXByb2YyAQAAAAAAAAACAAAAAAAAAA==");
+ byte[] bytes =
Base64.getDecoder().decode("Ae++Q3wDAe++QwHvvkO+uv7K776t3gAAAAAAAAAABm5vZGUwBmhvc3QwuRcBC3Jlc3QtaG9zdDBRvAMCBXV"
Review Comment:
Why change it?
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/ClusterStatePersistentSerializerTest.java:
##########
@@ -60,7 +62,7 @@ void serializationAndDeserializationWithNulls() {
.cmgNodes(Set.of("a", "b"))
.metaStorageNodes(Set.of("c", "d"))
.version("3.0.0")
- .clusterTag(ClusterTag.randomClusterTag(CMG_MESSAGES_FACTORY,
"cluster"))
+ .clusterTag(ClusterTag.clusterTag(CMG_MESSAGES_FACTORY,
"cluster", new UUID(0x1234567890ABCDEFL, 0xFEDCBA0987654321L)))
Review Comment:
Why change it?
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/ClusterStatePersistentSerializerTest.java:
##########
@@ -73,17 +75,19 @@ void serializationAndDeserializationWithNulls() {
@Test
void v1CanBeDeserialized() {
- byte[] bytes =
Base64.getDecoder().decode("Ae++QwMBYQFiAwFjAWQFMy4wLjAHY2x1c3Rlcp1Ct7dR35ELuoeboFbabrgHY29uZmlnAztFBahaoEfJtxGam"
- + "Q6WXJNFRfruL76Bv254dP54iF6V");
+ byte[] bytes =
Base64.getDecoder().decode("Ae++QwMCYgJhAwJkAmMGMy4wLjAIY2x1c3Rlcu/Nq5B4VjQSIUNlhwm63P4HY29uZmlnA+/Nq5B4VhI0IUN"
Review Comment:
Why change it?
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/topology/api/LogicalNodeSerializerTest.java:
##########
@@ -36,7 +36,7 @@ class LogicalNodeSerializerTest {
@Test
void serializationAndDeserialization() {
LogicalNode originalNode = new LogicalNode(
- UUID.randomUUID(),
+ new UUID(0x1234567890ABCDEFL, 0xFEDCBA0987654321L),
Review Comment:
Why change it?
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/ClusterStatePersistentSerializerTest.java:
##########
@@ -43,9 +42,12 @@ void serializationAndDeserializationWithoutNulls() {
.cmgNodes(Set.of("a", "b"))
.metaStorageNodes(Set.of("c", "d"))
.version("3.0.0")
- .clusterTag(ClusterTag.randomClusterTag(CMG_MESSAGES_FACTORY,
"cluster"))
+ .clusterTag(ClusterTag.clusterTag(CMG_MESSAGES_FACTORY,
"cluster", new UUID(0x1234567890ABCDEFL, 0xFEDCBA0987654321L)))
.initialClusterConfiguration("config")
- .formerClusterIds(List.of(randomUUID(), randomUUID()))
+ .formerClusterIds(List.of(
Review Comment:
Why change it?
##########
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/LocalStateStorageTest.java:
##########
@@ -69,7 +69,7 @@ void serializationAndDeserialization() {
@Test
void v1CanBeDeserialized() {
- vault.put(new ByteArray("cmg_state"),
Base64.getDecoder().decode("Ae++QwMBYQFiB2NsdXN0ZXLvzauQeFY0EiFDZYcJutz+"));
+ vault.put(new ByteArray("cmg_state"),
Base64.getDecoder().decode("Ae++QwMCYQJiCGNsdXN0ZXLvzauQeFY0EiFDZYcJutz+"));
Review Comment:
Why change it?
##########
modules/network-api/src/test/java/org/apache/ignite/internal/network/ClusterNodeSerializerTest.java:
##########
@@ -51,11 +51,11 @@ void serializationAndDeserialization() {
@Test
void v1CanBeDeserialized() {
- byte[] bytes =
Base64.getDecoder().decode("Ae++Q5FHweYb0PNweo7gWHuyYaUEdGVzdARob3N0uRcBCGV4dC1ob3N0uhe7Fw==");
+ byte[] bytes =
Base64.getDecoder().decode("Ae++Q+/Nq5B4VjQSIUNlhwm63P4FdGVzdAVob3N0uRcBCWV4dC1ob3N0uhe7Fw==");
ClusterNode restoredNode = VersionedSerialization.fromBytes(bytes,
serializer);
- assertThat(restoredNode.id(),
equalTo(UUID.fromString("70f3d01b-e6c1-4791-a561-b27b58e08e7a")));
+ assertThat(restoredNode.id(), equalTo(new UUID(0x1234567890ABCDEFL,
0xFEDCBA0987654321L)));
Review Comment:
Why change it?
##########
modules/network-api/src/test/java/org/apache/ignite/internal/network/ClusterNodeSerializerTest.java:
##########
@@ -34,7 +34,7 @@ class ClusterNodeSerializerTest {
@Test
void serializationAndDeserialization() {
ClusterNode originalNode = new ClusterNodeImpl(
- UUID.randomUUID(),
+ new UUID(0x1234567890ABCDEFL, 0xFEDCBA0987654321L),
Review Comment:
Why change it?
##########
modules/network-api/src/test/java/org/apache/ignite/internal/network/ClusterNodeSerializerTest.java:
##########
@@ -51,11 +51,11 @@ void serializationAndDeserialization() {
@Test
void v1CanBeDeserialized() {
- byte[] bytes =
Base64.getDecoder().decode("Ae++Q5FHweYb0PNweo7gWHuyYaUEdGVzdARob3N0uRcBCGV4dC1ob3N0uhe7Fw==");
+ byte[] bytes =
Base64.getDecoder().decode("Ae++Q+/Nq5B4VjQSIUNlhwm63P4FdGVzdAVob3N0uRcBCWV4dC1ob3N0uhe7Fw==");
Review Comment:
Why change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
