sk0x50 commented on code in PR #4580:
URL: https://github.com/apache/ignite-3/pull/4580#discussion_r1804700165
##########
modules/network-api/src/main/java/org/apache/ignite/internal/network/ClusterService.java:
##########
@@ -57,7 +57,6 @@ public interface ClusterService extends IgniteComponent {
/** {@inheritDoc} */
@Override
default CompletableFuture<Void> stopAsync(ComponentContext
componentContext) {
Review Comment:
> such default implementation is error-prone.
IMHO, it sounds arguable. On the other hand, the API should be symmetric I
think. This means that if we have a default implementation for `stopAsync` then
it would be nice to add a default implementation of `startAsync` as well (or
remove them both). Anyway, it looks to me that such an improvement is out of
the scope of the ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
