zstan commented on code in PR #4584:
URL: https://github.com/apache/ignite-3/pull/4584#discussion_r1808194765
##########
modules/sql-engine/src/integrationTest/sql/types/char/test_char.test:
##########
@@ -6,26 +6,24 @@
query T rowsort
SELECT ' prefix' || c1 || 'trailing ' FROM (VALUES('1 '::CHAR(5)), ('
2'::CHAR(5)), (''::CHAR(5)), (null)) t(c1);
----
- prefix 2 trailing
- prefix1 trailing
- prefix trailing
+ prefix 2trailing
+ prefix1 trailing
Review Comment:
seems we still bit incompatible here with PG, do we need to add right space
padding ?
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/fun/SameFamilyOperandTypeChecker.java:
##########
@@ -55,7 +55,7 @@ public boolean checkOperandTypes(SqlCallBinding callBinding,
boolean throwOnFail
@Override
public Consistency getConsistency() {
- return Consistency.LEAST_RESTRICTIVE;
+ return Consistency.NONE;
Review Comment:
seems now it`s identical to super method and can be removed
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/coercion/CharacterStringComparisonExecutionTest.java:
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine.exec.coercion;
+
+import
org.apache.ignite.internal.sql.engine.planner.datatypes.utils.CharacterStringPair;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.EnumSource;
+
+/** Check execution results for numeric comparisons. */
+public class CharacterStringComparisonExecutionTest extends
BaseTypeCheckExecutionTest {
+ @ParameterizedTest
+ @EnumSource
+ public void comparisonEq(CharacterStringPair typePair) throws Exception {
+ try (ClusterWrapper testCluster = testCluster(typePair,
dataProvider(typePair))) {
+ testCluster.process("SELECT c1 = c2 FROM t", checkReturnResult());
+ }
+ }
+
+ @ParameterizedTest
+ @EnumSource
+ public void comparisonLessEq(CharacterStringPair typePair) throws
Exception {
+ try (ClusterWrapper testCluster = testCluster(typePair,
dataProvider(typePair))) {
+ testCluster.process("SELECT c1 <= c2 FROM t", checkReturnResult());
+ }
+ }
+
+ @ParameterizedTest
+ @EnumSource
+ public void comparisonGreatEq(CharacterStringPair typePair) throws
Exception {
+ try (ClusterWrapper testCluster = testCluster(typePair,
dataProvider(typePair))) {
+ testCluster.process("SELECT c1 >= c2 FROM t", checkReturnResult());
+ }
+ }
+
+ @ParameterizedTest
+ @EnumSource
+ public void comparisonLess(CharacterStringPair typePair) throws Exception {
+ try (ClusterWrapper testCluster = testCluster(typePair,
dataProvider(typePair))) {
+ testCluster.process("SELECT c1 < c2 FROM t", checkReturnResult());
+ }
+ }
+
+ @ParameterizedTest
+ @EnumSource
+ public void comparisonGreat(CharacterStringPair typePair) throws Exception
{
+ try (ClusterWrapper testCluster = testCluster(typePair,
dataProvider(typePair))) {
+ testCluster.process("SELECT c1 < c2 FROM t", checkReturnResult());
Review Comment:
the same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
