sanpwc commented on code in PR #4581:
URL: https://github.com/apache/ignite-3/pull/4581#discussion_r1808256131
##########
modules/core/src/main/java/org/apache/ignite/internal/hlc/ClockService.java:
##########
@@ -31,13 +31,29 @@ public interface ClockService {
*/
HybridTimestamp now();
+ /**
+ * Gets a current timestamp. It is a fast way to get timestamp because it
does not have to update internal state.
Review Comment:
I'd rather say "doesn't have to tick the logical part of the clock". Within
the context of hybric clock that should be more clear. Here and in other
comments.
##########
modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java:
##########
@@ -85,6 +85,13 @@ public long nowLong() {
}
}
+ @Override
+ public long currentLong() {
+ long now = currentTime();
Review Comment:
Let's use "current" here in order not to mess with "now" where "now" is
unique.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
