ygerzhedovich commented on code in PR #4599:
URL: https://github.com/apache/ignite-3/pull/4599#discussion_r1808938740
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlCreateTable.java:
##########
@@ -49,33 +49,37 @@ protected Operator(boolean existFlag) {
public SqlCall createCall(@Nullable SqlLiteral functionQualifier,
SqlParserPos pos,
@Nullable SqlNode... operands) {
return new IgniteSqlCreateTable(pos, existFlag(), (SqlIdentifier)
operands[0], (SqlNodeList) operands[1],
- (SqlNodeList) operands[2], (SqlNodeList) operands[3]);
+ (SqlNodeList) operands[2], (SqlIdentifier) operands[3],
(SqlLiteral) operands[4]);
}
}
private final SqlIdentifier name;
+ @Nullable
Review Comment:
yes, fixed
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/ddl/DdlSqlToCommandConverterTest.java:
##########
@@ -613,12 +609,12 @@ public Stream<DynamicTest> timestampWithTzWithDefaults() {
@Test
public void tableWithAutogenPkColumn() throws SqlParseException {
- var node = parse("CREATE TABLE t (id uuid default rand_uuid primary
key, val int) WITH STORAGE_PROFILE='"
+ var node = parse("CREATE TABLE t (id uuid default rand_uuid primary
key, val int) STORAGE PROFILE '"
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
