rpuch commented on code in PR #4540:
URL: https://github.com/apache/ignite-3/pull/4540#discussion_r1810704162
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -282,6 +279,10 @@ private void
onWriteBusy(Iterator<CommandClosure<WriteCommand>> iterator) {
updateTrackerIgnoringTrackerClosedException(safeTime,
safeTimePropagatingCommand.safeTime());
}
+ // Completing the closure out of the partition snapshots lock to
reduce possibility of deadlocks as it might
+ // trigger other actions taking same locks.
+ clo.result(result);
Review Comment:
The comment is about partition snapshots read lock acquired by
`storage.acquirePartitionSnapshotsReadLock()`. I don't see how changes in this
PR (in the lines we are discussing) might cause any deadlock related to that
lock, so it's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
