sashapolo commented on code in PR #4630:
URL: https://github.com/apache/ignite-3/pull/4630#discussion_r1816527689
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##########
@@ -789,8 +789,6 @@ public void testCompositeScanRequest(int requestAmount1,
int requestAmount2, boo
if (tx != null) {
tx.rollback();
}
-
- assertThat(scanned, willCompleteSuccessfully());
Review Comment:
According to the `Subscription#cancel` javadocs:
```
/**
* Causes the Subscriber to (eventually) stop receiving
* messages. Implementation is best-effort -- additional
* messages may be received after invoking this method.
* A cancelled subscription need not ever receive an
* {@code onComplete} or {@code onError} signal.
*/
public void cancel();
```
Since in this test we cancel the subscription, we cannot expect that
`onComplete` (which completes the future) will be called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
