sashapolo commented on code in PR #4624:
URL: https://github.com/apache/ignite-3/pull/4624#discussion_r1816592532
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -1345,13 +1345,19 @@ public ChecksumAndRevisions checksumAndRevisions(long
revision) {
}
}
- private long minChecksummedRevisionOrZero() {
+ private long minChecksummedRevisionOrZero() throws RocksDBException {
try (
- var options = new ReadOptions();
+ var options = new ReadOptions().setTailing(true);
RocksIterator it = revisionToChecksum.newIterator(options)
) {
it.seekToFirst();
- return it.isValid() ? bytesToLong(it.key()) : 0;
+
+ if (it.isValid()) {
+ it.status();
Review Comment:
This should be used the opposite way, actually) You need to check the status
only if the iterator is not valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
