rpuch commented on code in PR #4670:
URL: https://github.com/apache/ignite-3/pull/4670#discussion_r1828904136
##########
modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridTimestamp.java:
##########
@@ -131,7 +132,18 @@ public static long hybridTimestampToLong(@Nullable
HybridTimestamp timestamp) {
* @param bytes Byte array representing a timestamp.
*/
public static HybridTimestamp fromBytes(byte[] bytes) {
- return hybridTimestamp(ByteUtils.bytesToLong(bytes));
+ // Reversing bytes as ByteUtils works in BE, but we store in LE (as
IgniteDataOutput uses LE and we want to be consistent between
Review Comment:
Documented the format in the class javadoc. But a comment in the method is
still needed as it's talking about a non-obvious implementation detail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
