JAkutenshi commented on code in PR #4707:
URL: https://github.com/apache/ignite-3/pull/4707#discussion_r1840950280
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -412,7 +412,7 @@ private void updateLeaseBatchInternal() {
if (!lease.isAccepted()) {
LeaseAgreement agreement =
leaseNegotiator.getAndRemoveIfReady(grpId);
- agreement.checkValid(grpId,
topologyTracker.currentTopologySnapshot(), assignments);
+ agreement.checkValid(grpId,
topologyTracker.currentTopologySnapshot(), stableAssignments);
Review Comment:
Hm, I'm not sure there: lease on pendings set is an exceptional situation
and I guess It's a good idea to invalidate pending lease and grant it to a node
from stables. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
