AMashenkov commented on code in PR #4697:
URL: https://github.com/apache/ignite-3/pull/4697#discussion_r1841963156
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/MappingServiceImpl.java:
##########
@@ -220,7 +231,9 @@ private CompletableFuture<MappedFragments> mapFragments(
return res.thenApply(assignments -> {
Int2ObjectMap<ExecutionTarget> targetsById = new
Int2ObjectOpenHashMap<>();
- MappingContext context = new MappingContext(localNodeName, new
ArrayList<>(assignments.nodes()), template.cluster);
+ MappingContext context = new MappingContext(
+ localNodeName, new
ArrayList<>(assignments.nodes(nodeExclusionFilter)), template.cluster
Review Comment:
Do we need a copy to ArrayList here if filter is null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]