rpuch commented on code in PR #4725:
URL: https://github.com/apache/ignite-3/pull/4725#discussion_r1843677666
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java:
##########
@@ -1117,32 +1118,34 @@ public void updateLease(
return null;
}
- AbstractWriteBatch writeBatch = requireWriteBatch();
+ saveLease(requireWriteBatch(), leaseStartTime,
primaryReplicaNodeId, primaryReplicaNodeName);
- try {
- ByteArrayOutputStream outputStream = new
ByteArrayOutputStream();
- outputStream.write(longToBytes(leaseStartTime));
+ return null;
+ });
+ }
- byte[] primaryReplicaNodeIdBytes =
uuidToBytes(primaryReplicaNodeId);
- outputStream.write(primaryReplicaNodeIdBytes);
+ private void saveLease(AbstractWriteBatch writeBatch, long leaseStartTime,
UUID primaryReplicaNodeId, String primaryReplicaNodeName) {
+ try {
+ ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
Review Comment:
Please note that in this case only lease information is updated, not the
whole partition metadata.
I like the idea to make this format versioned, filed an issue
https://issues.apache.org/jira/browse/IGNITE-23683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
