rpuch commented on code in PR #4733:
URL: https://github.com/apache/ignite-3/pull/4733#discussion_r1846589086
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/disaster/ItDisasterRecoverySystemViewTest.java:
##########
@@ -178,4 +186,21 @@ private static int getTableId(String schemaName, String
tableName) {
return
catalogManager.catalog(catalogManager.latestCatalogVersion()).table(schemaName,
tableName).id();
}
+
+ private static long estimatedSize(String nodeName, String tableName, int
partitionId) {
+ return CLUSTER.runningNodes()
+ .filter(ignite -> nodeName.equals(ignite.name()))
+ .map(ignite -> {
+ IgniteImpl node = ((RestartProofIgnite)
CLUSTER.node(0)).unwrap(IgniteImpl.class);
+
+ TableImpl table = ((PublicApiThreadingTable)
node.tables().table(tableName)).unwrap(TableImpl.class);
Review Comment:
You can just do
`TableImpl table =
TestWrappers.unwrapTableImpl(ignite.tables().table(tableName))`
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/disaster/ItDisasterRecoverySystemViewTest.java:
##########
@@ -131,7 +135,11 @@ void
testLocalPartitionStatesSystemViewWithUpdatedEstimatedSize() throws Excepti
// Small wait is specially added so that the follower can execute the
replicated "insert" command and the counter is honestly
// increased.
Review Comment:
Do we still need this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
