sanpwc commented on code in PR #4688:
URL: https://github.com/apache/ignite-3/pull/4688#discussion_r1847962944
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/GroupUpdateRequest.java:
##########
@@ -272,19 +302,28 @@ private static CompletableFuture<Integer> partitionUpdate(
null
);
} else {
- Set<Assignment> stableAssignments = Set.copyOf(partAssignments);
+ assert !partAssignments.isEmpty() : "Alive nodes with data should
not be empty";
+
+ List<Assignment> nextAssignments = new
ArrayList<>(partAssignments);
+
+ nextAssignments.sort(
Review Comment:
Hmm, not sure that I get it. It's required to choose the node with max
lastLogId as forced one. And the sorting should be stable if there are multiple
nodes with same logIndex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
