timoninmaxim commented on code in PR #11660:
URL: https://github.com/apache/ignite/pull/11660#discussion_r1851919975


##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java:
##########
@@ -817,7 +819,11 @@ private <T> T applyOnDefaultChannel(
         ClientOperation op,
         @Nullable List<ClientConnectionException> failures
     ) {
-        while (attemptsLimit > (failures == null ? 0 : failures.size())) {
+        // +1 is required for the correct channel search if 
ReliableChannel#applyOnDefaultChannel#idx selects

Review Comment:
   An additional attempt is needed because N+1 channels might be used for 
sending a message - first a random one, then each one from #channels in 
sequence.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to