sanpwc commented on code in PR #4446:
URL: https://github.com/apache/ignite-3/pull/4446#discussion_r1869000669
##########
modules/replicator/src/main/java/org/apache/ignite/internal/raft/client/TopologyAwareRaftGroupService.java:
##########
@@ -305,14 +305,16 @@ private static boolean recoverable(Throwable t) {
* @return Future that is completed when all subscription messages to
peers are sent.
*/
public CompletableFuture<Void> subscribeLeader(LeaderElectionListener
callback) {
- assert !serverEventHandler.isSubscribed() : "The node already
subscribed";
+ if (serverEventHandler.isSubscribed()) {
Review Comment:
That's is bit messy. The fact that we once set callback to
serverEventHandler and if it was already initialised - add it to
eventsClientListener while we also add serverEventHandler to
eventsClientListener. That should be refactored. Please create jira and add
TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
