korlov42 commented on code in PR #4814:
URL: https://github.com/apache/ignite-3/pull/4814#discussion_r1869610684
##########
modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/JdbcStatement.java:
##########
@@ -90,6 +92,8 @@ public class JdbcStatement implements Statement {
/** Current result index. */
private int curRes;
+ private volatile @Nullable Long lastCorrelationToken;
Review Comment:
first, I believe this is semantically more correct (null means there is no
last value). Second, given that token generator wraps around, I don't want to
deal with collision with this special value in generator (even though the
chance to stumble upon collision is close to zero)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
