Phillippko commented on code in PR #4887:
URL: https://github.com/apache/ignite-3/pull/4887#discussion_r1883389631
##########
modules/core/src/main/java/org/apache/ignite/internal/tostring/ClassDescriptor.java:
##########
@@ -17,19 +17,22 @@
package org.apache.ignite.internal.tostring;
+import static
org.apache.ignite.internal.tostring.ToStringUtils.createStringifier;
+
import java.util.ArrayList;
import java.util.Comparator;
import java.util.List;
+import org.jetbrains.annotations.Nullable;
/**
* Simple class descriptor containing simple and fully qualified class names
as well as the list of class fields.
*/
class ClassDescriptor {
- /** Class simple name. */
- private final String sqn;
+ /** Class name. */
+ private final String name;
- /** Class FQN. */
- private final String fqn;
+ /** Class stringifier, {@code null} id absent. */
Review Comment:
```suggestion
/** Class stringifier, {@code null} if absent. */
```
##########
modules/network-annotation-processor/src/main/java/org/apache/ignite/internal/network/processor/messages/MessageImplGenerator.java:
##########
@@ -137,12 +139,20 @@ public TypeSpec generateMessageImpl(MessageClass message,
TypeSpec builderInterf
if (getter.getAnnotation(IgniteToStringExclude.class) == null) {
IgniteToStringInclude includeAnnotation =
getter.getAnnotation(IgniteToStringInclude.class);
-
- AnnotationSpec includeAnnotationSpec = includeAnnotation ==
null
- ?
AnnotationSpec.builder(IgniteToStringInclude.class).build()
- : AnnotationSpec.get(includeAnnotation);
-
- fieldBuilder.addAnnotation(includeAnnotationSpec);
+ IgniteStringifier stringifierAnnotation =
getter.getAnnotation(IgniteStringifier.class);
+
+ if (stringifierAnnotation != null) {
Review Comment:
IgniteToStringInclude (and it's fields) is ignored if IgniteStringifier is
set -> sensitive field is lost
##########
modules/network-annotation-processor/src/test/java/org/apache/ignite/internal/network/processor/tests/OtherMessages.java:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.network.processor.tests;
+
+import java.util.List;
+import java.util.UUID;
+import org.apache.ignite.internal.network.NetworkMessage;
+import org.apache.ignite.internal.network.annotations.Transferable;
+import org.apache.ignite.internal.tostring.IgniteStringifier;
+import org.apache.ignite.internal.tostring.SizeOnlyStringifier;
+import org.jetbrains.annotations.Nullable;
+
+/** Other massages. */
Review Comment:
Is it an easter egg for me?
```suggestion
/** Other messages. */
```
or maybe "Test messages that don't belong to any other group"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
