ygerzhedovich commented on code in PR #4908:
URL: https://github.com/apache/ignite-3/pull/4908#discussion_r1890224799
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java:
##########
@@ -112,11 +89,6 @@ private boolean doBinaryComparisonCoercion(SqlCallBinding
binding) {
validateBinaryComparisonCoercion(binding, leftType, rightType,
(IgniteSqlValidator) validator);
- // If types are equal, no need in coercion.
- if (leftType.equals(rightType)) {
- return false;
- }
-
// Otherwise find the least restrictive type among the operand types
Review Comment:
Why previous part for equals types has been deleted - it looked like as fast
path for such a case.
Even if it was a garbage need to amend the comment, due to it's strange to
see 'Otherwise bla-bla-bla'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
