Phillippko commented on code in PR #4931:
URL: https://github.com/apache/ignite-3/pull/4931#discussion_r1893730687
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -783,6 +783,35 @@ public void removeAll(List<byte[]> keys,
KeyValueUpdateContext context) {
}
}
+ @Override
+ public void removeAll(byte[] prefix, KeyValueUpdateContext context) {
+ rwLock.writeLock().lock();
+
+ try (WriteBatch batch = new WriteBatch(); Cursor<Entry> entries =
range(prefix, nextKey(prefix))) {
+ long curRev = rev + 1;
+
+ List<byte[]> keys = new ArrayList<>();
Review Comment:
Only for RocksDB, yes? For SimpleInMemoryKeyValueStorage it seems impossible
to avoid accumulating keys to a collection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
