xtern commented on code in PR #4929:
URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1895360962
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -1140,8 +1140,7 @@ public class IgniteImpl implements Ignite {
clientHandlerModule = new ClientHandlerModule(
qryEngine,
distributedTblMgr,
- // TODO: IGNITE-20232 The observable timestamp should be
different for each client.
- new IgniteTransactionsImpl(txManager, new
HybridTimestampTracker()),
+ txManager,
Review Comment:
can we also fix the last TODO related to IGNITE-20232 (in
IgniteTransactionsImpl?):
```
TODO:IGNITE-20232 Remove this method; instead, an interface method should be
used.
```
and close INIGTE-20232 when this will be resolved?
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -743,16 +757,18 @@ private void processOperation(ChannelHandlerContext ctx,
ClientMessageUnpacker i
return ClientJdbcColumnMetadataRequest.process(in, out,
jdbcQueryEventHandler);
case ClientOp.JDBC_SCHEMAS_META:
- return ClientJdbcSchemasMetadataRequest.process(in, out,
jdbcQueryEventHandler);
+ return ClientJdbcSchemasMetadataRequest.process(in, out,
jdbcQueryEventHandler).thenRun(() -> {
+ out.meta(clockService.current());
Review Comment:
why we need to update timestamp when requesting metadata?
why most time we updating it conditionally?
```
if (!(out.meta() instanceof HybridTimestamp))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
