xtern commented on code in PR #4959:
URL: https://github.com/apache/ignite-3/pull/4959#discussion_r1897322970
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/AccumulatorsFactory.java:
##########
@@ -142,26 +142,24 @@ private static Function<Object, Object>
compileCast(IgniteTypeFactory typeFactor
* TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
*/
public AccumulatorsFactory(
- ExecutionContext<RowT> ctx,
Review Comment:
Can we remove TODO?
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/AccumulatorsFactory.java:
##########
@@ -57,7 +57,7 @@
* AccumulatorsFactory.
* TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
*/
-public class AccumulatorsFactory<RowT> implements
Supplier<List<AccumulatorWrapper<RowT>>> {
+public class AccumulatorsFactory<RowT> {
Review Comment:
Let's fix javadoc and remove `TODO`?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
