rpuch commented on code in PR #4974:
URL: https://github.com/apache/ignite-3/pull/4974#discussion_r1898512641
##########
modules/client/src/test/java/org/apache/ignite/client/fakes/FakeInternalTable.java:
##########
@@ -147,6 +147,7 @@ public CompletableFuture<BinaryRow> get(BinaryRowEx keyRow,
@Nullable InternalTr
public CompletableFuture<BinaryRow> get(
BinaryRowEx keyRow,
HybridTimestamp readTimestamp,
+ @Nullable UUID transactionId,
Review Comment:
Exactly, I did not want to block on the decision we would take on this
matter, and also I did not want to touch in this PR the tests that would be
affected, so I moved this to another issue. And I would also prefer to only
leave a method accepting transaction object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
