ibessonov commented on code in PR #4997: URL: https://github.com/apache/ignite-3/pull/4997#discussion_r1910374375
########## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/configuration/NodeAttributeConfigurationSchema.java: ########## @@ -35,6 +35,6 @@ public class NodeAttributeConfigurationSchema { public String name; /** Node attribute field. */ - @Value(hasDefault = true) + @InjectedValue(hasDefault = true) Review Comment: We should replace `hasDefault` with the opposite `mandatory` or something, because it sucks to always have this option set to true, makes schemas uglier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org