oleg-vlsk commented on code in PR #11793:
URL: https://github.com/apache/ignite/pull/11793#discussion_r1912378341
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/performancestatistics/PerformanceStatisticsThinClientTest.java:
##########
@@ -169,6 +176,10 @@ public void testCacheOperation() throws Exception {
checkCacheOperation(CACHE_REMOVE_ALL, cache ->
cache.removeAll(Collections.singleton(3)));
checkCacheOperation(CACHE_GET_AND_REMOVE, cache ->
cache.getAndRemove(5));
+
+ checkCacheOperation(CACHE_PUT_ALL_CONFLICT,
putAllConflict(Collections.singletonMap(6, 1)));
Review Comment:
I suggest extracting these checks into separate test methods. Having too
many checks in a single test reduces readability and maintainability, and makes
it harder to pinpoint the issue when the test fails.
Using a singleton collection seems unnecessary since we're testing just one
key-value pair. While it's essential for previous tests that rely on actual
APIs, here we utilize our own test methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
