nizhikov commented on code in PR #11811:
URL: https://github.com/apache/ignite/pull/11811#discussion_r1916246831
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionSupplier.java:
##########
@@ -444,8 +444,7 @@ else if (iter.isPartitionMissing(p)) {
if (grp.shared().kernalContext().isStopping())
return;
- // Sending supply messages with error requires new protocol.
- boolean sendErrMsg =
demanderNode.version().compareTo(GridDhtPartitionSupplyMessageV2.AVAILABLE_SINCE)
>= 0;
+ boolean sendErrMsg = true;
Review Comment:
Let's rewrite it more clear:
```
boolean sendErrMsg = !(t instanceof IgniteSpiException);
if (sendErrMsg) {
U.error(log, "Failed to continue supplying ["
+ supplyRoutineInfo(topicId, nodeId, demandMsg) + ']',
t);
}
else if (log.isDebugEnabled())
log.debug("Failed to send message to node (current node is
stopping?) ["
+ supplyRoutineInfo(topicId, nodeId, demandMsg) + ",
msg=" + t.getMessage() + ']');
try {
if (sctx != null)
clearContext(sctx, log);
}
catch (Throwable t1) {
U.error(log, "Failed to cleanup supplying context ["
+ supplyRoutineInfo(topicId, nodeId, demandMsg) + ']',
t1);
}
if (!sendErrMsg)
return;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
