tkalkirill commented on code in PR #5045: URL: https://github.com/apache/ignite-3/pull/5045#discussion_r1916310122
########## modules/configuration-annotation-processor/src/main/java/org/apache/ignite/internal/configuration/processor/ClassWrapper.java: ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.configuration.processor; + +import static java.util.stream.Collectors.toList; +import static javax.lang.model.element.Modifier.STATIC; +import static org.apache.ignite.internal.configuration.processor.ConfigurationProcessorUtils.sameType; + +import java.lang.annotation.Annotation; +import java.util.List; +import javax.annotation.processing.ProcessingEnvironment; +import javax.lang.model.element.ElementKind; +import javax.lang.model.element.TypeElement; +import javax.lang.model.element.VariableElement; +import javax.lang.model.type.TypeMirror; +import org.apache.ignite.internal.util.Lazy; +import org.jetbrains.annotations.Nullable; + +/** + * A wrapper around a class (represented by a {@link TypeElement}) with some helper methods. + */ +public class ClassWrapper { + private final ProcessingEnvironment processingEnvironment; + + private final TypeElement clazz; + + private final List<VariableElement> fields; + + private final Lazy<ClassWrapper> superClass = new Lazy<>(this::computeSuperClass); + + /** Constructor. */ + public ClassWrapper(ProcessingEnvironment processingEnvironment, TypeElement clazz) { + this.processingEnvironment = processingEnvironment; + this.clazz = clazz; + this.fields = fields(clazz); + } + + public TypeElement clazz() { + return clazz; + } + + public <A extends Annotation> A getAnnotation(Class<A> annotationType) { + return clazz.getAnnotation(annotationType); + } + + /** + * Returns the superclass of the class, or {@code null} if the superclass is {@link Object}. + */ + public @Nullable ClassWrapper superClass() { + return superClass.get(); + } + + /** + * Returns the superclass of the class, or throws {@link ConfigurationValidationException} if the superclass is {@link Object}. + */ + public ClassWrapper requiredSuperClass() { + ClassWrapper superClass = superClass(); + + if (superClass == null) { + throw new ConfigurationValidationException(this, "Must have a superclass"); Review Comment: I think it's better to just throw `NullPointerException` in the same way as in `java.util.Objects#requireNonNull(T)`, since formally there is no validation here and it should be in another place. ########## modules/configuration-annotation-processor/src/main/java/org/apache/ignite/internal/configuration/processor/ClassWrapper.java: ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.configuration.processor; + +import static java.util.stream.Collectors.toList; +import static javax.lang.model.element.Modifier.STATIC; +import static org.apache.ignite.internal.configuration.processor.ConfigurationProcessorUtils.sameType; + +import java.lang.annotation.Annotation; +import java.util.List; +import javax.annotation.processing.ProcessingEnvironment; +import javax.lang.model.element.ElementKind; +import javax.lang.model.element.TypeElement; +import javax.lang.model.element.VariableElement; +import javax.lang.model.type.TypeMirror; +import org.apache.ignite.internal.util.Lazy; +import org.jetbrains.annotations.Nullable; + +/** + * A wrapper around a class (represented by a {@link TypeElement}) with some helper methods. + */ +public class ClassWrapper { + private final ProcessingEnvironment processingEnvironment; + + private final TypeElement clazz; + + private final List<VariableElement> fields; + + private final Lazy<ClassWrapper> superClass = new Lazy<>(this::computeSuperClass); Review Comment: Please tell me why we need to use `Lazy`, maybe we can calculate it right away when initializing the object in the constructor, similar to fields? ########## modules/configuration-annotation-processor/src/main/java/org/apache/ignite/internal/configuration/processor/ConfigurationProcessor.java: ########## @@ -162,9 +169,11 @@ private boolean process0(RoundEnvironment roundEnvironment) { // Find all the fields of the schema. List<VariableElement> fields = fields(clazz); Review Comment: Are these by any chance the same fields that will be present in `ClassWrapper`? If so, I think we can get rid of this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
