rpuch commented on code in PR #5093:
URL: https://github.com/apache/ignite-3/pull/5093#discussion_r1926536273
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/configuration/TransactionConfigurationSchema.java:
##########
@@ -41,10 +41,29 @@ public class TransactionConfigurationSchema {
@Value(hasDefault = true)
public final long timeout = 10_000;
- /** Timeout for implicit transactions (milliseconds). */
@Range(min = 1)
@Value(hasDefault = true)
- public final long implicitTransactionTimeout = 3_000;
+ public final long minRoTimeout = 1;
+
+ @Range(min = 1)
+ @Value(hasDefault = true)
+ public final long maxRoTimeout = Long.MAX_VALUE;
Review Comment:
There was a proposal to switch duration-related properties type to
`Duration` and allow the user specify units in the config. Having this in mind,
it seems that we should not include units in property names.
My comment only makes sense if we still want to have that feature in the
configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
