rpuch commented on code in PR #5093: URL: https://github.com/apache/ignite-3/pull/5093#discussion_r1930295418
########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ########## @@ -418,7 +418,9 @@ public class TableManager implements IgniteTablesInternal, IgniteComponent { private final PartitionReplicaLifecycleManager partitionReplicaLifecycleManager; - private long implicitTransactionTimeout; + private long roTransactionTimeout; Review Comment: >In that case why roTransactionTimeout and rwTransactionTimeout are here? I thought these properties define *default* TX timeouts. A default is global and not specific to a transaction. ########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ########## @@ -418,7 +418,9 @@ public class TableManager implements IgniteTablesInternal, IgniteComponent { private final PartitionReplicaLifecycleManager partitionReplicaLifecycleManager; - private long implicitTransactionTimeout; + private long roTransactionTimeout; Review Comment: >In that case why roTransactionTimeout and rwTransactionTimeout are here? I thought these properties define *default* TX timeouts. A default is global and not specific to a transaction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org