AMashenkov commented on code in PR #5112:
URL: https://github.com/apache/ignite-3/pull/5112#discussion_r1930440624
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogService.java:
##########
@@ -42,7 +34,8 @@
* <li>Events are fired in the metastore thread.</li>
* </ul>
*
- * <p>TBD: events
+ * @see CatalogEvent Full list of events, which is fired by the catalog
service.
+ * @see CatalogManager The manager, which provides catalog manipulation
methods and is responsible for managing distributed operations.
*/
public interface CatalogService extends EventProducer<CatalogEvent,
CatalogEventParameters> {
Review Comment:
I'm not sure we need @Nullable annotation on `@Nullable Catalog catalog(int
catalogVersion)`,
because we never expect a null-value.
As I see everywhere in code, we use a version in between earliest and
latest, or have an `assert catalog != null;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
