sashapolo commented on code in PR #5113:
URL: https://github.com/apache/ignite-3/pull/5113#discussion_r1930563074
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageHashIndexDescriptor.java:
##########
@@ -93,7 +94,7 @@ public String toString() {
* @param index Catalog index descriptor.
*/
public StorageHashIndexDescriptor(CatalogTableDescriptor table,
CatalogHashIndexDescriptor index) {
- this(index.id(), extractIndexColumnsConfiguration(table, index),
!index.isCreatedWithTable());
+ this(index.id(), extractIndexColumnsConfiguration(table, index),
index.status() == CatalogIndexStatus.REGISTERED);
Review Comment:
@ibessonov could you please remind us, why we used to deduce this value from
a flag in the Catalog? I remember we had a discussion and you insisted on this
approach based on the simplicity of the rebalance algorithm.
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageHashIndexDescriptor.java:
##########
@@ -93,7 +94,7 @@ public String toString() {
* @param index Catalog index descriptor.
*/
public StorageHashIndexDescriptor(CatalogTableDescriptor table,
CatalogHashIndexDescriptor index) {
- this(index.id(), extractIndexColumnsConfiguration(table, index),
!index.isCreatedWithTable());
+ this(index.id(), extractIndexColumnsConfiguration(table, index),
index.status() == CatalogIndexStatus.REGISTERED);
Review Comment:
@ibessonov could you please remind me, why we used to deduce this value from
a flag in the Catalog? I remember we had a discussion and you insisted on this
approach based on the simplicity of the rebalance algorithm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
