sanpwc commented on code in PR #5134:
URL: https://github.com/apache/ignite-3/pull/5134#discussion_r1939062237
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -210,6 +212,8 @@ public class PartitionReplicaLifecycleManager extends
/** Configuration of rebalance retries delay. */
private final SystemDistributedConfigurationPropertyHolder<Integer>
rebalanceRetryDelayConfiguration;
+ private final ConcurrentMap<ZonePartitionId, ZonePartitionRaftListener>
zonePartitionRaftListeners = new ConcurrentHashMap<>();
Review Comment:
I'd rather add something like addTableProcessor method to the replica in
order to substitute
`((ZonePartitionReplicaListener)
replicaFut.join().listener()).addTableReplicaListener(tablePartitionId,
createListener);` with something like
`replicaFut.join().addTableProcessor(tablePartitionId, createListener,
tableRaftListener)` in
`PartitionReplicaLifecycleManager#loadTableListenerToZoneReplica`
`addTableReplicaListener` should be removed in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
