xtern commented on code in PR #5143:
URL: https://github.com/apache/ignite-3/pull/5143#discussion_r1939642342
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -496,23 +514,6 @@ private AsyncDataCursor<InternalSqlRow> executeKill(
return new IteratorToDataCursorAdapter<>(ret, Runnable::run);
}
- private static RuntimeException convertDdlException(Throwable e) {
- e = ExceptionUtils.unwrapCause(e);
-
- if (e instanceof ConfigurationChangeException) {
- assert e.getCause() != null;
- // Cut off upper configuration error`s as uninformative.
- e = e.getCause();
- }
-
- if (e instanceof IgniteInternalCheckedException) {
- return new IgniteInternalException(INTERNAL_ERR, "Failed to
execute DDL statement [stmt=" /* + qry.sql() */
- + ", err=" + e.getMessage() + ']', e);
- }
-
- return (e instanceof RuntimeException) ? (RuntimeException) e : new
IgniteInternalException(INTERNAL_ERR, e);
Review Comment:
It looks like the same error handling should be removed when handling the
KILL command... :pensive:
But we can probably do it separately later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
