zstan commented on code in PR #5145:
URL: https://github.com/apache/ignite-3/pull/5145#discussion_r1942345851
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java:
##########
@@ -284,7 +284,11 @@ public boolean querySourceCoercion(
@Override
protected boolean needToCast(SqlValidatorScope scope, SqlNode node,
RelDataType toType) {
RelDataType fromType = validator.deriveType(scope, node);
- if (SqlTypeUtil.isInterval(toType)) {
+
+ // No need to cast between binary types.
+ if (SqlTypeUtil.isBinary(toType) && SqlTypeUtil.isBinary(fromType)) {
+ return false;
+ } else if (SqlTypeUtil.isInterval(toType)) {
Review Comment:
i fill some tests, probably they need some extensions but they cover a diff
for this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
