JAkutenshi commented on code in PR #5170:
URL: https://github.com/apache/ignite-3/pull/5170#discussion_r1942848658
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItColocationTest.java:
##########
@@ -341,6 +341,7 @@ public NetworkMessage clone() {
intTable = new InternalTableImpl(
QualifiedNameHelper.fromNormalized(SqlCommon.DEFAULT_SCHEMA_NAME, "TEST"),
+ 2, // zone id.
Review Comment:
It's related too, but as local variable close to the constructor.
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/TableScanNodeExecutionTest.java:
##########
@@ -263,7 +263,8 @@ private static class TestInternalTableImpl extends
InternalTableImpl {
) {
super(
QualifiedNameHelper.fromNormalized(SqlCommon.DEFAULT_SCHEMA_NAME, "test"),
- 1,
+ 2, // zone id.
Review Comment:
What do you think if we extract the values as constant fields with the
corresponding names? Commentaries are better then nothing, but any test class
may be evolved and commentary may be erased and so on.
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/message/TableAware.java:
##########
@@ -20,9 +20,10 @@
import org.apache.ignite.internal.network.NetworkMessage;
/**
- * Generic interface for all messages about concrete table.
+ * This class represents a common base interface for all message types related
to a particular table.
+ * Extending this interface means the message is propagated to the table
replica to be processed via zone replica.
*/
public interface TableAware extends NetworkMessage {
- /** Table Id. */
+ /** Returns table identifier. **/
Review Comment:
`Returns an identifier of a table for which one the message is intended
(related?)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
