sanpwc commented on PR #5179: URL: https://github.com/apache/ignite-3/pull/5179#issuecomment-2647118144
Generally, your solution is good and addresses much more than a single test problem. I believe that you've fixed 4 scenarios of node recovery. 1. Local log application during node recovery on start. There's a raft log with some entries targeted towards some tables that aren't ready. 2. Local snapshot recovery during local node recovery on start when raft is already started, but some tables aren't ready. 3. External raft log command application during -//-. 4. External snapshot application during -//-. Thus. Could you please 1. Update the description of the ticket? 2. Update PR cation? 3. Either write corresponding tests to cover missing ones (see aforementioned scenarios) or create a ticket to add them later since currently it's not fully possible because snapshots aren't ready yet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
