sk0x50 commented on code in PR #5197:
URL: https://github.com/apache/ignite-3/pull/5197#discussion_r1948964406
##########
modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunner.java:
##########
@@ -403,10 +412,11 @@ CompletableFuture<Void> propagateTimeToLocalReplicas(long
txBeginTime) {
return schemaSyncService.waitForMetadataCompleteness(nowTs)
.thenComposeAsync(ignore -> {
- Int2IntMap tablesWithPartitions =
-
catalogManagerFacade.collectTablesWithPartitionsBetween(txBeginTime,
nowTs.longValue());
+ Int2IntMap idsWithPartitions = enabledColocationFeature
+ ?
catalogManagerFacade.collectZonesWithPartitionsBetween(txBeginTime,
nowTs.longValue())
+ :
catalogManagerFacade.collectTablesWithPartitionsBetween(txBeginTime,
nowTs.longValue());
- ObjectIterator<Entry> itr =
tablesWithPartitions.int2IntEntrySet().iterator();
+ ObjectIterator<Entry> itr =
idsWithPartitions.int2IntEntrySet().iterator();
Review Comment:
Yes, your are right.
##########
modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunner.java:
##########
@@ -403,10 +412,11 @@ CompletableFuture<Void> propagateTimeToLocalReplicas(long
txBeginTime) {
return schemaSyncService.waitForMetadataCompleteness(nowTs)
.thenComposeAsync(ignore -> {
- Int2IntMap tablesWithPartitions =
-
catalogManagerFacade.collectTablesWithPartitionsBetween(txBeginTime,
nowTs.longValue());
+ Int2IntMap idsWithPartitions = enabledColocationFeature
+ ?
catalogManagerFacade.collectZonesWithPartitionsBetween(txBeginTime,
nowTs.longValue())
+ :
catalogManagerFacade.collectTablesWithPartitionsBetween(txBeginTime,
nowTs.longValue());
- ObjectIterator<Entry> itr =
tablesWithPartitions.int2IntEntrySet().iterator();
+ ObjectIterator<Entry> itr =
idsWithPartitions.int2IntEntrySet().iterator();
Review Comment:
Yes, you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
