sanpwc commented on code in PR #5225:
URL: https://github.com/apache/ignite-3/pull/5225#discussion_r1954390197
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -707,14 +709,20 @@ public CompletableFuture<Replica> startReplica(
(raftClient) -> new ReplicaImpl(
replicaGrpId,
createListener.apply(raftClient),
- storageIndexTracker,
- clusterNetSvc.topologyService().localMember(),
- executor,
+ localNode,
placementDriver,
- clockService,
- replicaStateManager::reserveReplica,
getPendingAssignmentsSupplier,
- failureManager
+ failureManager,
+ new PlacementDriverMessageProcessor(
Review Comment:
It'll be
```
(raftClient) -> {
var placementDriverMessageProcessor = new
PlacementDriverMessageProcessor(
replicaGrpId,
localNode,
placementDriver,
clockService,
replicaStateManager::reserveReplica,
executor,
storageIndexTracker,
raftClient
);
return new ReplicaImpl(
replicaGrpId,
createListener.apply(raftClient),
localNode,
placementDriver,
getPendingAssignmentsSupplier,
failureManager,
placementDriverMessageProcessor
);
}
```
From my point of view it looks worse. Besides it's used only as ReplicaImpl
constructor parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
