alievmirza commented on code in PR #5092:
URL: https://github.com/apache/ignite-3/pull/5092#discussion_r1954754538
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -159,29 +133,10 @@ public class DistributionZoneManager extends
/** Executor for scheduling tasks for scale up and scale down processes. */
private final StripedScheduledThreadPoolExecutor executor;
- /**
- * Map with states for distribution zones. States are needed to track
nodes that we want to add or remove from the data nodes,
- * schedule and stop scale up and scale down processes.
- */
- private final Map<Integer, ZoneState> zonesState = new
ConcurrentHashMap<>();
+ private DataNodesManager dataNodesManager;
/** Listener for a topology events. */
- private final LogicalTopologyEventListener topologyEventListener = new
LogicalTopologyEventListener() {
- @Override
- public void onNodeJoined(LogicalNode joinedNode,
LogicalTopologySnapshot newTopology) {
- updateLogicalTopologyInMetaStorage(newTopology);
- }
-
- @Override
- public void onNodeLeft(LogicalNode leftNode, LogicalTopologySnapshot
newTopology) {
- updateLogicalTopologyInMetaStorage(newTopology);
- }
-
- @Override
- public void onTopologyLeap(LogicalTopologySnapshot newTopology) {
- updateLogicalTopologyInMetaStorage(newTopology);
- }
- };
+ private final LogicalTopologyEventListener topologyEventListener = new
DistributionZoneManagerLogicalTopologyEventListener();
/**
* The logical topology mapped to the MS revision.
Review Comment:
check note on `logicalTopologyByRevision`, It refers the
https://issues.apache.org/jira/browse/IGNITE-23561 -- ticket that you are going
to close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
