rpuch commented on code in PR #5295:
URL: https://github.com/apache/ignite-3/pull/5295#discussion_r1971462738
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -273,7 +274,13 @@ public class PartitionReplicaListener implements
ReplicaListener {
private static final ReplicaMessagesFactory REPLICA_MESSAGES_FACTORY = new
ReplicaMessagesFactory();
/** Replication group id. */
- private final TablePartitionId replicationGroupId;
+ // TODO https://issues.apache.org/jira/browse/IGNITE-22522 Use
ZonePartitionId instead.
+ private final PartitionGroupId replicationGroupId;
+
+ private final int tableId;
+
+ // Despite the fact that it's correct to use replicationGroupId as lock
key it's better to preserver slightly higher lock granularity.
Review Comment:
```suggestion
// Despite the fact that it's correct to use replicationGroupId as lock
key it's better to preserve slightly higher lock granularity.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
