tkalkirill commented on code in PR #5276:
URL: https://github.com/apache/ignite-3/pull/5276#discussion_r1981404099


##########
modules/index/src/main/java/org/apache/ignite/internal/index/ChangeIndexStatusTaskController.java:
##########
@@ -153,46 +159,84 @@ private void onIndexRemoved(RemoveIndexEventParameters 
parameters) {
 
     private void onPrimaryReplicaElected(PrimaryReplicaEventParameters 
parameters) {
         inBusyLock(busyLock, () -> {
-            TablePartitionId primaryReplicaId = (TablePartitionId) 
parameters.groupId();
+
+            PartitionGroupId primaryReplicaId = (PartitionGroupId) 
parameters.groupId();
 
             if (primaryReplicaId.partitionId() != 0) {
                 // We are only interested in the 0 partition.
                 return;
             }
 
-            int tableId = primaryReplicaId.tableId();
-
             if (isLocalNode(clusterService, parameters.leaseholderId())) {
-                if (localNodeIsPrimaryReplicaForTableIds.add(tableId)) {
-                    scheduleTasksOnPrimaryReplicaElectedBusy(tableId);
-                }
+                scheduleTasksOnPrimaryReplicaElectedBusy(primaryReplicaId);
             } else {
-                if (localNodeIsPrimaryReplicaForTableIds.remove(tableId)) {
-                    changeIndexStatusTaskScheduler.stopTasksForTable(tableId);
-                }
+                scheduleStopTasksOnPrimaryReplicaElected(primaryReplicaId);
             }
         });
     }
 
-    private void scheduleTasksOnPrimaryReplicaElectedBusy(int tableId) {
+    private void scheduleTasksOnPrimaryReplicaElectedBusy(PartitionGroupId 
partitionGroupId) {
         // It is safe to get the latest version of the catalog because the 
PRIMARY_REPLICA_ELECTED event is handled on the metastore thread.
         Catalog catalog = 
catalogService.catalog(catalogService.latestCatalogVersion());
 
-        for (CatalogIndexDescriptor indexDescriptor : 
catalog.indexes(tableId)) {
-            switch (indexDescriptor.status()) {
-                case REGISTERED:
-                    
changeIndexStatusTaskScheduler.scheduleStartBuildingTask(indexDescriptor);
+        IntArrayList tableIds = getTableIdsForPrimaryReplicaElected(catalog, 
partitionGroupId);
 
-                    break;
+        localNodeIsPrimaryReplicaForTableIds.addAll(tableIds);
 
-                case STOPPING:
-                    
changeIndexStatusTaskScheduler.scheduleRemoveIndexTask(indexDescriptor);
+        IntListIterator tableIdsIterator = tableIds.iterator();
+        while (tableIdsIterator.hasNext()) {

Review Comment:
   I think a regular loop looks more natural and familiar than an iterator, 
especially in this case.



##########
modules/index/src/main/java/org/apache/ignite/internal/index/ChangeIndexStatusTaskController.java:
##########
@@ -153,46 +159,84 @@ private void onIndexRemoved(RemoveIndexEventParameters 
parameters) {
 
     private void onPrimaryReplicaElected(PrimaryReplicaEventParameters 
parameters) {
         inBusyLock(busyLock, () -> {
-            TablePartitionId primaryReplicaId = (TablePartitionId) 
parameters.groupId();
+
+            PartitionGroupId primaryReplicaId = (PartitionGroupId) 
parameters.groupId();
 
             if (primaryReplicaId.partitionId() != 0) {
                 // We are only interested in the 0 partition.
                 return;
             }
 
-            int tableId = primaryReplicaId.tableId();
-
             if (isLocalNode(clusterService, parameters.leaseholderId())) {
-                if (localNodeIsPrimaryReplicaForTableIds.add(tableId)) {
-                    scheduleTasksOnPrimaryReplicaElectedBusy(tableId);
-                }
+                scheduleTasksOnPrimaryReplicaElectedBusy(primaryReplicaId);
             } else {
-                if (localNodeIsPrimaryReplicaForTableIds.remove(tableId)) {
-                    changeIndexStatusTaskScheduler.stopTasksForTable(tableId);
-                }
+                scheduleStopTasksOnPrimaryReplicaElected(primaryReplicaId);
             }
         });
     }
 
-    private void scheduleTasksOnPrimaryReplicaElectedBusy(int tableId) {
+    private void scheduleTasksOnPrimaryReplicaElectedBusy(PartitionGroupId 
partitionGroupId) {
         // It is safe to get the latest version of the catalog because the 
PRIMARY_REPLICA_ELECTED event is handled on the metastore thread.
         Catalog catalog = 
catalogService.catalog(catalogService.latestCatalogVersion());
 
-        for (CatalogIndexDescriptor indexDescriptor : 
catalog.indexes(tableId)) {
-            switch (indexDescriptor.status()) {
-                case REGISTERED:
-                    
changeIndexStatusTaskScheduler.scheduleStartBuildingTask(indexDescriptor);
+        IntArrayList tableIds = getTableIdsForPrimaryReplicaElected(catalog, 
partitionGroupId);

Review Comment:
   Do I understand correctly that we need to select those tables that were not 
added earlier? And method 123, as I understand it, returns existing ones? Is 
there an error here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to