sanpwc commented on code in PR #5484:
URL: https://github.com/apache/ignite-3/pull/5484#discussion_r2010060420
##########
modules/index/src/test/java/org/apache/ignite/internal/index/IndexBuilderTest.java:
##########
@@ -174,7 +175,8 @@ private void scheduleBuildIndex(int indexId, int zoneId,
int tableId, int partit
indexStorage(nextRowIdsToBuild),
mock(MvPartitionStorage.class),
mock(ClusterNode.class),
- ANY_ENLISTMENT_CONSISTENCY_TOKEN
+ ANY_ENLISTMENT_CONSISTENCY_TOKEN,
+ mock(HybridTimestamp.class)
Review Comment:
It's not clear which timestamp should I use (0, 0)? (10, 10)? By choosing
"random" value I may mistakenly break some invariants or forcefully set
unexpected one. I believe that mock is better here. The fact that test will
fail (currently it's not) in case of some unexpected null is actually a good
thing that will highlight some some invariants are broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
